[WIP] Using Http Laravel client instead of Curl #153
+124
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeildo-jr
changed the title
Member
|
Very nice, let me know when this is ready for review. I'd accept a similar PR at spatie/laravel-webhook-client |
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
|
Hello! Was this reviewed? Or why rejected? I'm trying to use this package and noticed I can't use Http::fake() to test. Is there anymore information on why this didn't go ahead? |
Member
|
It is marked as draft, so that's why we don't review it. Is this PR ready? If so mark it as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #145, this will replace Curl client with Http client from Laravel. There's many advantages to use Http client.
All idea and code that I'm using goes to hailwood, as he published his custom job using Http client.
I'll describe later all breaking changes from this, as it is a WIP.
Right now, my only concern is about to send XML or other content such as plain/text.
Any advice is welcome.