-
-
Notifications
You must be signed in to change notification settings - Fork 233
Wide PDFs, Antialiasing, Minor Improvements #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces enhancements to PDF handling, updates the CI workflow for parallel testing and PHP 8.4 support, and adds new test utility functions.
- Enhanced support for ultra-wide and wide PDFs with antialiasing improvements.
- New test utilities and tests for PDF size validation.
- Improved CI workflow including updated sed commands and parallel test execution.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/Unit/WidthTest.php | Added tests to validate ultra-wide and wide PDF dimensions. |
tests/Pest.php | Introduced utility functions for test file handling. |
src/Pdf.php | Updated PDF class to support nullable Imagick and antialiasing toggles. |
README.md | Added documentation for ultra-wide PDF policy configuration. |
.github/workflows/run-tests.yml | Updated PHP matrix, sed commands for Imagick policy, and enabled parallel tests. |
Co-authored-by: Copilot <[email protected]>
ping @freekmurze @sebastiandedeyne - need a quick review for this PR, as time permits. thanks! 👍 |
This PR introduces several enhancements and fixes across the codebase, focusing on improving PDF handling, updating workflows, and adding new test utilities. Key changes include updates to support ultra-wide PDFs, enhancements to the CI workflow, and new helper functions for testing.
It resolves #245, which adds antialias support when saving images, and #248, which is a bug report indicating ultra-wide PDFs cannot be loaded. The docs have been updated to reflect the changes necessary in the Imagick policy config file to allow loading these files.
Enhancements to PDF Handling:
Imagick
policy configuration and documenting the process in theREADME.md
. [1] [2]Pdf
class to initializeImagick
as nullable and replaced null checks withempty()
for better readability and flexibility. [1] [2] [3]Continuous Integration Workflow Improvements:
.github/workflows/run-tests.yml
to include PHP 8.4.policy.xml
file on the test runner is updated to allow for ultra-wide PDFs.Testing Enhancements:
get_test_file
,test_file
, andoutput_file
) intests/Pest.php
to streamline test file handling.WidthTest.php
file to validate support for ultra-wide and wide PDFs, ensuring proper functionality and output.Other