Add SDA Workflow by mcopik · Pull Request #277 · spcl/serverless-benchmarks

mcopik · 2026-01-06T15:57:03Z

Tasks to accomplish:

Identical configuration for Redis and Memgraph
Build instructions for the custom image.

[still dependent on apt to install pip]

… too

modifying sda benchmark data

coderabbitai · 2026-01-06T15:57:11Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2389bb1a-4aba-4e80-94ab-8a260d33c9c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/sda-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mcopik · 2026-01-06T15:58:55Z

benchmarks/600.workflows/610.gen/definition.json

            "type": "map",
            "array": "astros.people",
-            "root": "map_astros",
+            "root": "map",


Not sure why this change is necessary - need to check.

I ran into issue trying to run this on AWS since the task name shadows the function name

.vscode/launch.json

.vscode/settings.json

benchmarks/600.workflows/6300.sda-workflow/dev/data/sda-workflow-local.json

benchmarks/600.workflows/6300.sda-workflow/dev/debug.sh

mcopik · 2026-03-10T15:49:41Z

benchmarks/600.workflows/6300.sda-workflow/config.json

+  "memory": 128,
+  "languages": ["python"],
+  "modules": ["storage"],
+  "container-image": "logru/sda-no-db:latest"


This is good but it would be great if we had a clear path to reproduce these images - @LoloGruber, can you please point me to this Dockerfile? On the main branch, we have now C++ support that gives us a way to add "dependencies" images, and I can integrate that.

I added code to container.py to build an image by injecting aws bootstrap code to a user-defined base image. This is the related Dockerfile for AWS

I meant the Dockerfile that builds SDA :-) I don't see it in the Dockerfile you linked.

Sorry, there you go:
https://gitlab2.informatik.uni-wuerzburg.de/descartes/sos/sda-workflow/-/blob/main/prod/docker/Dockerfile.base?ref_type=heads

mcopik · 2026-03-10T15:53:57Z

benchmarks/600.workflows/6300.sda-workflow/input.py

+import json
+import os
+
+class MemgraphConfig:


This is a comment for me - we need to integrate it internaly, just like we did with the config for Redis.

mcopik · 2026-03-10T15:54:48Z

config/systems.json

-          "module_packages": {}
+          "module_packages": {
+            "storage": [
+              "boto3"


Interesting - I guess it's a side-effect of using a custom Docker image?

No, this is required to be able to transfer files via upload_func to S3. I think the workflows branch was previously only tested on Azure.

We tested the workflow on all three providers.

I suspect something else: previously, functions were deployed as code packages on AWS (so AWS provides runtime with boto3) or as containers, and these containers inherit from a base image that is AWS-specific and already contains boto3. If we now support a custom container base image that is not AWS-specific, so boto3 is missing.

Ah okay, that makes sense

mcopik · 2026-03-10T16:00:19Z

sebs/benchmark.py

        ],
        is_workflow: bool,
    ) -> Tuple[bool, str, bool, str]:
+        # Check if custom container image is specified which would collide with container deployment option


I'm wondering if it should not be reversed - if the benchmark specified a custom container image, then shouldn't we instead throw an error when non-container (code package) deployment is selected? Because that is a clear contradiction.

You are correct, I didnt want to make any big changes to the code flow of SeBS, but I would also rather deny any other types of deployment if a custom image is specified

I will just remove this check and force a container deployment when a custom image is specified

mcopik · 2026-03-10T16:01:55Z

sebs/aws/aws.py

                f'"{self.config.resources.redis_password}"',
            )
-
+        assert not (code_package.container_deployment and code_package.benchmark_config.container_image is not None), \


As noted in a different comment - I think it should be an error to try to deploy a benchmark with custom image in the "code package" mode (non-container).

As you see in the branching below, for me, it is a third option to deploy a function. Code-Package (Python functions as zip), Container (Python functions within image), User-defined Container (containing the Python functions and SeBS boilerplate code). I wanted to avoid the user using the flag --container-deployment and also specifying a custom base image. If you agree, I think it would be a valid approach to overrule this flag when a custom image is defined

…eployment, forcing a custom image deployment

LoloGruber added 30 commits November 4, 2025 16:49

updating ignore

9b30024

fixing dummy workflow

93c1fe5

vscode run config. to be removed later

c4ef107

fix call site to create_function

c9fa196

adapt to changed signature

5de04ed

fixing state machine

60143bf

adjusting temporary vscode debug config

fab742a

adding redis configs to gitignore

3c846d0

fixing demo workflow

19027fe

fix: function update from cache

790ad27

fix: state machine encoding of switch case variable

c954fd5

updating ignore

e10af40

adding skeleton for sda workflow

39af6e5

adding another launch config for debugging

840a76f

working on lambda base image for custom containers

a9f882a

working on custom aws containers

f64a661

flag not necessary when deploying user containers

88ca99f

moving dev stuff

c3cf46c

adding debug script for container

bc197ad

testing native binaries inside aws container

96605d2

rearrange order for better caching

00ca219

testing with actual data

e0b24f7

testing container deployment of sebs vs custom

7ecc0be

adding option to specify custom container for benchmark

9a3dacb

aws base image to include lamdba bootstrap code

0d08618

[still dependent on apt to install pip]

splitting registry info function to get information for custom images…

360f3ef

… too

building custom container

4850ef3

adding boto3 to storage module packages for aws

856bd9a

working on file transfer

0bdd2da

load custom image container from cache if avail

e429c8a

LoloGruber added 11 commits November 27, 2025 14:56

store outputs in output bucket

bcac8e9

(wip) file management

1f15d22

runnable chaining of first two sda steps

a35cce5

call update instead of create

634a960

modifying sda benchmark data

sda workflow implementation

8696869

restore old version

b5735ec

adding initial split step to workflow. enable parallel filter/neighbors

90e6528

adding different experiment sizes to sda workflow

5ca3c46

changing timeout

4a3ec64

adding additional launch option for large benchmark

9f6979b

updating data

af79eb4

mcopik commented Jan 6, 2026

View reviewed changes

updating config

ea636c6

mcopik commented Mar 10, 2026

View reviewed changes

LoloGruber added 3 commits March 12, 2026 11:00

updating ignore to exclude vs code files

3a17d79

removing development artifacts

eb805d0

removed checks for simultaneous containerized deployment and custom d…

af35601

…eployment, forcing a custom image deployment

Conversation

mcopik commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcopik commented Jan 6, 2026 •

edited

Loading

coderabbitai bot commented Jan 6, 2026 •

edited

Loading