-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automatic-Module-Name #66
base: master
Are you sure you want to change the base?
Conversation
- Add Automatic-Module-Name: `org.spdx.spdxRdfStore` Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this particular repo requires Java 11, we should implement a module.info file instead of an automatic module file.
Thank you. Will try that. Btw, I'm not sure about the casing convention of the module name. Should it be all lowercase? The documentation here only discussed package names: |
From [this pull request](Btw, I'm not sure about the casing convention of the module name. Should it be all lowercase?), I'm assuming all lowercase is preferred. |
Currently, the package name is Should we also change that? (in another PR) That will be |
Let's leave the package name the same for compatibility reasons. We can go with all lowercase for the module name. |
org.spdx.spdxRdfStore