Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Automatic-Module-Name #66

wants to merge 2 commits into from

Conversation

bact
Copy link
Collaborator

@bact bact commented Feb 27, 2025

  • Add Automatic-Module-Name: org.spdx.spdxRdfStore

- Add Automatic-Module-Name: `org.spdx.spdxRdfStore`

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from goneall February 27, 2025 11:27
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this particular repo requires Java 11, we should implement a module.info file instead of an automatic module file.

@bact
Copy link
Collaborator Author

bact commented Feb 28, 2025

Thank you. Will try that.

Btw, I'm not sure about the casing convention of the module name. Should it be all lowercase?

The documentation here only discussed package names:
https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html

@goneall
Copy link
Member

goneall commented Feb 28, 2025

Btw, I'm not sure about the casing convention of the module name. Should it be all lowercase?

From [this pull request](Btw, I'm not sure about the casing convention of the module name. Should it be all lowercase?), I'm assuming all lowercase is preferred.

@bact
Copy link
Collaborator Author

bact commented Feb 28, 2025

Currently, the package name is org.spdx.spdxRdfStore

For example, https://github.com/spdx/spdx-java-rdf-store/blob/master/src/main/java/org/spdx/spdxRdfStore/CompatibilityUpgrader.java

Should we also change that? (in another PR)

That will be org.spdx.spdxrdfstore (which can be quite difficult to read -- the tagvalue store does not have this issue though, because it uses the package name org.spdx.tag)

@goneall
Copy link
Member

goneall commented Feb 28, 2025

Currently, the package name is org.spdx.spdxRdfStore

For example, https://github.com/spdx/spdx-java-rdf-store/blob/master/src/main/java/org/spdx/spdxRdfStore/CompatibilityUpgrader.java

Should we also change that? (in another PR)

That will be org.spdx.spdxrdfstore (which can be quite difficult to read -- the tagvalue store does not have this issue though, because it uses the package name org.spdx.tag)

Let's leave the package name the same for compatibility reasons.

We can go with all lowercase for the module name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants