feat: support autofilling of sdkClassName and packageName #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x session in quickstart
adaam2
force-pushed
the
fix/schema-store-additional-fields
branch
from
d8d0aa3 to
609cb7c
Compare
chase-crumbaugh
approved these changes
Apr 7, 2025
| @@ -308,19 +310,26 @@ func getValuesForField( | |||
| if field.Description != nil { | |||
| description = *field.Description | |||
| } | |||
| if field.Name == "packageName" && isQuickstart && sdkClassName != "" { | |||
| if field.Name == "packageName" && isQuickstart { | |||
There was a problem hiding this comment.
What is the significance of omitting sdkClassName from this if?
There was a problem hiding this comment.
Means that it will be shown by default which I think is ok
| packageName := sdkClassName | ||
|
|
||
| if quickstart.IsUsingTemplate && quickstart.Defaults.TemplateData != nil { | ||
| packageName = quickstart.Defaults.TemplateData.PackageName |
There was a problem hiding this comment.
Is packageName never empty/default? Do we want to prefer sdkClassName if they didn't choose a specific packageName? Maybe not
There was a problem hiding this comment.
No i dont think so - we do prefer it currently - this is just the case of using a template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support to the quickstart command to automatically fill the settings values for
sdkClassNameandpackageNamefrom a session in the Speakeasy Sandbox (sandbox.speakeasy.com)Demo
CleanShot.2025-04-07.at.12.54.49.mp4