remove requirement for btchip-python dependency#9426
Closed
gitaccount798 wants to merge 1 commit intospesmilo:masterfrom
Closed
remove requirement for btchip-python dependency#9426gitaccount798 wants to merge 1 commit intospesmilo:masterfrom
gitaccount798 wants to merge 1 commit intospesmilo:masterfrom
Conversation
no longer needed
gitaccount798
changed the title
Author
|
Just a comment that I will not have the time to fix this, especially with the learning curve I would need, so I am happy for someone else work on this pull request. |
Member
|
closing in favour of #9652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #9370 and LedgerHQ/app-bitcoin-new#309.
ledger_bitcoinalready ships with a copy of thebtchipmodule andbtchip-pythonis unmaintained and archived as of Oct 14, 2024.Despite
btchip-pythonno longer being used in electrum (except only for HW.1), as of the upgrade to Ubuntu 24.04 with a newersetuptoolsthat is unable to parsebtchip-python, it causes an error that disables access with a Ledger (in my case a Nano S) to Electrum.For the above reasons, it seems to me that the solution is to remove the requirement for
btchip-pythondependency.I am not very experienced in coding (not experienced at all really), but I thought I would propose this pull request and have an initial attempt in amending the code to get a discussion for a solution for the issue going.