Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve site formatting #2183

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Improve site formatting #2183

merged 3 commits into from
Oct 12, 2024

Conversation

nirs
Copy link
Contributor

@nirs nirs commented Aug 24, 2024

- Separate titles with blank lines
- Separate code blocks with blank lines
- Always use ``` blocks for examples
- Use console for console (bash syntax highlighting does work well with
  example command output)
- Start console examples with $ (highlight command and output
  differently and more friendly to other shells users)
When we want to show a minimal example with single import it looks
cleaner and more minimal with a single line.
your.go
commands.go
here.go
main.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if main.go is indented correctly. We can replace it with tree output which is much more clear to users and also used later below.

appName
├── cmd
│   ├── add.go
│   ├── your.go
│   ├── commands.go
│   └── here.go
└── main.go

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, feel free to change this if you prefer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow-up 😄

@nirs nirs changed the title Site formatting Improve site formatting Aug 24, 2024
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thanks!

@marckhouzam marckhouzam merged commit ff7c561 into spf13:main Oct 12, 2024
18 checks passed
@marckhouzam marckhouzam added this to the 1.9.0 milestone Oct 12, 2024
@marckhouzam marckhouzam modified the milestones: 1.8.1, 1.9.0 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants