Closes #2193 #2194
Open
Closes #2193 #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Re-pushed and removed check completely - parent context can never be nil so no point checking |
- Comment states check parent, code checked child instead - No point performing parent check as code above ensures that this is never nil
AtricoSoftware
force-pushed
the
#2193-Incorrect_copy_of_context_from_parent_to_child
branch
from
bcffb99
to
81a7781
Compare
|
I concur. This issue makes it very hard to use Cobra in tests so this would be a great fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context is not copied from parent to child
Comment on code states copy if parent has context but code implements copy if child doesn't have context
Fix makes behaviour consistent between root and sub commands w.r.t. contexts