Skip to content

Conversation

@OkieOth
Copy link

@OkieOth OkieOth commented Oct 20, 2025

This is the promised PR for issue #2320. Although I like the experience, are the changes in the project a bit harsch.

If you reject this PR, I will release the changes in a dedicated extension lib.

I am looking forward.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

Thanks @OkieOth. A couple of things:

  1. You will need to sign the CLA. See automated comment above.
  2. Can you describe in the PR description what this PR does? If you include a concrete example of how a project or user of cobra would make use of this change, it will be very useful.

module github.com/spf13/cobra

go 1.15
go 1.24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because cobra is used by so many projects, we cannot easily change the go version, or else we would force all our users to update their go version, which can be a big task.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the go version and provide a proper example documentation

@OkieOth
Copy link
Author

OkieOth commented Oct 21, 2025

Okay the used fuzzyfinder requires a newer go versions ... and I understand that this is a too big change for a widely used library. I will close my PR and will provide the changes in a separate lib.

@OkieOth OkieOth closed this Oct 21, 2025
@marckhouzam
Copy link
Collaborator

Thanks for trying @OkieOth , we appreciate getting to help the cobra community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants