Skip to content

Deprecate retry_bootstrap #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

kfox1111
Copy link
Contributor

@kfox1111 kfox1111 commented May 7, 2025

Partially-fixes: #5896

Signed-off-by: Kevin Fox <[email protected]>
Comment on lines +429 to +432
if c.Agent.RetryBootstrap {
ac.Log.Warn("The 'retry_bootstrap' configuration is deprecated. It will be enabled by default in SPIRE 1.13 and the option removed in SPIRE 1.14.")
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are unable to change default behaviors without a complete minor rotation, so we need to move this to 1.14, before removing,
And need to display this to users that are not using it.
Maybe something like this?

Suggested change
if c.Agent.RetryBootstrap {
ac.Log.Warn("The 'retry_bootstrap' configuration is deprecated. It will be enabled by default in SPIRE 1.13 and the option removed in SPIRE 1.14.")
}
if !c.Agent.RetryBootstrap {
ac.Log.Warn("The 'retry_bootstrap' configuration is going to be default in SPIRE 1.14 and the option removed in SPIRE 1.15.")
}

@kfox1111 kfox1111 marked this pull request as draft June 3, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing retry_bootstrap=false
2 participants