Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of brain_t1 list #150

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

mbondy023
Copy link
Contributor

These are additional subjects that were determined to not be processed accurately through freesurfer due to issues with the brain T1w image. Each scan's issue is noted in the exclude.yml file.

6 subjects added to brain_t1 list. 1 scan had motion artifacts and 5 scans had severe brain cut off after defacing (all could not be re-defaced).

6 subjects added to brain_t1 list. 1 scan had motion artifacts and 5 scans had severe brain cut off after defacing (all could not be re-defaced).
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! It looks fine to me.

I noticed that the automated check is failing, but it looks like a temporary download error, unrelated to your changes. I've re-started the check, hopefully it works this time.

@mguaypaq
Copy link
Member

Oh, I see what's going on: this pull request is coming from a fork of the repository, and that fork's git-annex branch is outdated. The dataset validator relies on having an updated git-annex branch to download all the data files, so it's failing.

The simplest way to fix this would be to update the fork's git-annex branch. @mbondy023, I'll open a pull request in your fork to do this. If/when you merge it, I can re-try the dataset validator in this pull request.

@mbondy023
Copy link
Contributor Author

mbondy023 commented Sep 18, 2023 via email

@mguaypaq mguaypaq merged commit 901964b into spine-generic:master Sep 18, 2023
1 check passed
@mguaypaq
Copy link
Member

The checks passed this time, thanks again!

@mbondy023
Copy link
Contributor Author

mbondy023 commented Sep 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants