Skip to content

node-installer: add integration test and add special handlings for k3s #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Mar 13, 2025

  • introduce a script to integration test the node-installer image
  • add a KWasm node installer job file for the integration test
  • modified the README to include instructions for building the image locally and running the integration tests

Signed-off-by: Jiaxiao (mossaka) Zhou [email protected]

- introduce a script to integration test the node-installer image
- add a KWasm node installer job file for the integration test
- modified the README to include instructions for building the image locally and running the integration tests

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka force-pushed the node-installer-integration-test branch from fe71828 to aca6e02 Compare March 13, 2025 00:22
Mossaka added 2 commits March 13, 2025 00:31
This includes integration tests for Kind, MiniKube, MicroK8s, and K3s.

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka force-pushed the node-installer-integration-test branch from e50bf66 to 63badf2 Compare March 13, 2025 21:52
@Mossaka Mossaka force-pushed the node-installer-integration-test branch from 1415aa2 to a9b0f86 Compare March 19, 2025 20:40
@Mossaka Mossaka requested a review from kate-goldenring March 19, 2025 20:57
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka force-pushed the node-installer-integration-test branch from a9b0f86 to c68b1c2 Compare March 19, 2025 22:46
@Mossaka Mossaka changed the title node-installer: add integration test node-installer: add integration test and add special handlings for k3s Mar 19, 2025
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a few clean up pointers that would be great to address but could also be done in a follow up

Mossaka added 4 commits March 20, 2025 18:35
- move the testing scripts to the `node-installer/tests/` directory
- move the kwasm-job.yml to the `node-installer/tests/workloads/` directory
- symlink the workload.yaml and runtime.yaml from the root `deployments/workloads/` to the `node-installer/tests/workloads/` directory

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka merged commit f1db060 into main Mar 20, 2025
13 checks passed
@Mossaka Mossaka deleted the node-installer-integration-test branch March 20, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants