Skip to content

enable search on docs #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

karthik2804
Copy link
Contributor

@karthik2804 karthik2804 commented May 7, 2025

This PR enables using search on the docs.

  • It also adds generating the search index for in CI using spin build

closes #7

@karthik2804 karthik2804 requested review from itowlson and vdice May 7, 2025 16:08
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to review all the THINGS but I did spot two dubious strings. #helping

Signed-off-by: Karthik Ganeshram <[email protected]>
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Thanks!

@vdice
Copy link
Contributor

vdice commented May 8, 2025

Build failure due to #96; bypassing this check and merging.

@vdice vdice merged commit 1d8984f into spinframework:main May 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement search functionality
4 participants