Conversation
| /// details of the system's thread scheduler. | ||
| /// | ||
| /// See [`wasmtime::Store::set_epoch_deadline`](https://docs.rs/wasmtime/latest/wasmtime/struct.Store.html#method.set_epoch_deadline). | ||
| pub fn set_deadline(&mut self, deadline: Instant) { |
There was a problem hiding this comment.
Based on some searching I'm reasonably confident that this method isn't being used anywhere (public).
crates/core/src/lib.rs
Outdated
There was a problem hiding this comment.
This arbitrarily updates the original arbitrary value, which "felt too slow" to me. 🤷
|
@lann what's the state of this? I thought this had already been merged. |
|
Uhh I think I lost track of this back when e2e tests were broken for a while. Will refresh. |
lann
force-pushed
the
yield-interval
branch
from
7d907df to
7bae4a1
Compare
|
@lann did this once again go stale? |
|
Yep, but it could still be reviewed and then I could just merge it after the next rebase 🙂 |
With async yielding, instance execution can be implemented by dropping the async call future, with e.g. tokio::time::timeout. Signed-off-by: Lann Martin <[email protected]>
|
Sorry I'm a year and a half late on this; is it still relevant? |
|
Oof I'll have to set a reminder to come back and check in the new year 😬 |
|
I'm going to go ahead and close this so it doesn't keep showing up on my GitHub "reviews requested" list. Feel free to reopen if it's still relevant. |
3 participants
With async yielding, instance execution can be implemented by dropping the async call future, with e.g. tokio::time::timeout.