feat(marketplace): also annotate nodes on upgrade to support shim upgrade #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rade Signed-off-by: Vaughn Dice <[email protected]>
Mossaka
approved these changes
Nov 7, 2024
| @@ -3,7 +3,7 @@ kind: Job | |||
| metadata: | |||
| name: "{{ .Release.Name }}-kwasm-annotate-nodes" | |||
| annotations: | |||
| "helm.sh/hook": post-install | |||
| "helm.sh/hook": post-install,post-upgrade | |||
There was a problem hiding this comment.
It seems fine to re-labeling nodes for both the post-install and post-upgrade scenarios. Have you tested this? I am asking because I am concerend about if we need to have buffer time of labeling kwasm-node from false to true.
There was a problem hiding this comment.
I have tested locally, though only on KinD. Maybe worth checking on AKS?
Oh, I could also add test coverage for this in our helm chart smoke test (or create a new workflow with scenarios like this)...
There was a problem hiding this comment.
I like the idea of adding more tests
vdice
force-pushed
the
feat/annotate-on-upgrade
branch
3 times, most recently
from
e27817e
to
f3178cb
Compare
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
feat/annotate-on-upgrade
branch
from
f3178cb
to
9d54816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also try to make this logic smarter, for instance if there was a way to know if we are executing via the 'helm-upgrade' hook, we could inspect which nodes are already labeled with
kwasm.sh/kwasm-node=trueand do the re-labeling just on this subset, rather than re-labeling all nodes. Thoughts?