Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(marketplace): update sku name in mainTemplate.json #37

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

vdice
Copy link
Collaborator

@vdice vdice commented Nov 8, 2024

Follow-up to #31

We bumped the managedCluster api version. I hadn't tested locally via eg az deployment create..., assuming our arm template verification would catch this, but it did not. I'll create a follow-up issue to see how we can catch such errors in the future.

@vdice vdice requested a review from Mossaka November 8, 2024 16:33
@vdice vdice merged commit bfd0632 into spinkube:main Nov 8, 2024
3 checks passed
@vdice vdice deleted the fix/main-template-base-sku branch November 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants