Use Spin telemetry crate #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kate-goldenring
commented
Jun 7, 2024
kate-goldenring
commented
- Ensures compatibility with containerd-shim-spin which already inits a tracing subscriber
- Bumps to latest Spin dependencies
kate-goldenring
commented
Jun 7, 2024
calebschoepp
approved these changes
Jun 7, 2024
- Ensures compatibility with containerd-shim-spin which already inits a tracing subscriber - Bumps to latest Spin dependencies Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
force-pushed
the
use-spin-telemetry
branch
from
89e1202
to
013c45b
Compare
Signed-off-by: Kate Goldenring <[email protected]>
|
@radu-matei can you give this a review -- I don't have the perms to add reviewers |
Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
requested review from
suneetnangia,
radu-matei,
karthik2804 and
fibonacci1729
as code owners
fibonacci1729
previously approved these changes
Aug 1, 2024
karthik2804
reviewed
Aug 1, 2024
src/lib.rs
Outdated
Comment on lines
208
to
213
| self.handle_mqtt_event( | ||
| &component_id, | ||
| msg.payload().to_vec(), | ||
| msg.topic().to_owned(), | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
I am not sure that the behavior here is the intended one. in case the guest returns an error, I think we will want to only log that error and continue the loop.
There was a problem hiding this comment.
Oh yeah good catch @karthik2804 . I forgot we did that to not return on an error.
There was a problem hiding this comment.
Wouldn't the error here come from the MQTT event source not the guest (Spin app)? I could see bubbling up the error as being useful to make the error more apparent to the user. But it does make sense to match existing behavior. It is now logging the error.
Signed-off-by: Kate Goldenring <[email protected]>
karthik2804
approved these changes
Aug 2, 2024
radu-matei
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.