fix(notifications): Prevent duplicate notifications for MJ #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirm it is working: |
...re/src/main/java/com/netflix/spinnaker/echo/notification/AbstractEventNotificationAgent.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/netflix/spinnaker/echo/notification/AbstractEventNotificationAgent.java
Outdated
Show resolved
Hide resolved
...est/groovy/com/netflix/spinnaker/echo/notification/AbstractEventNotificationAgentSpec.groovy
Show resolved
Hide resolved
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
shlomodaari
force-pushed
the
fix-manual-judgment-notifications
branch
from
b10f2bd to
db99ed2
Compare
jasonmcintosh
approved these changes
Apr 24, 2025
|
A docs PR might help on this btw ;) Will also get this backported... |
|
@Mergifyio backport release-1.36.x release-1.37.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Apr 24, 2025
…nt stages (#1506) (#1508) (cherry picked from commit 989e20b) Co-authored-by: Shlomo Daari <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 24, 2025
…nt stages (#1506) (#1507) (cherry picked from commit 989e20b) Co-authored-by: Shlomo Daari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fix for spinnaker/spinnaker#7051