case sensitivity on features

Author: Ben-Epstein

splicemachine/features/feature_store.py

@@ -1118,7 +1118,7 @@ def display_model_feature_drift(self, schema_name: str, table_name: str):
                                 self._auth, params={ "schema": schema_name, "table": table_name})['metadata']
 
         training_set_df, model_table_df = self._retrieve_model_data_sets(schema_name, table_name)
-        features = metadata['features'].split(',')
+        features = [f.upper() for f in metadata['features'].split(',')]
         build_feature_drift_plot(features, training_set_df, model_table_df)
 
 

splicemachine/features/utils/drift_utils.py

@@ -75,10 +75,8 @@ def build_feature_drift_plot(features, training_set_df, model_table_df):
     :param features: list of features to analyze
     :param training_set_df: the dataframe used for training the model that contains all the features to analyze
     :param model_table_df: the dataframe with the content of the model table containing all input features
-    :return: None
     """
-    upper_features = [f.upper() for f in features]
-    final_features = [f for f in upper_features if f in model_table_df.columns]
+    final_features = [f for f in features if f in model_table_df.columns]
     # prep plot area
     n_bins = 15
     num_features = len(final_features)