Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[display] fix render Chinese #438

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

[display] fix render Chinese #438

wants to merge 1 commit into from

Conversation

Darley-Wey
Copy link

No description provided.

@Darley-Wey Darley-Wey closed this Mar 12, 2024
@Darley-Wey
Copy link
Author

fix#437

@Darley-Wey Darley-Wey reopened this Mar 12, 2024
sea-bass
sea-bass reviewed Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought in Python 3, the "utf-8" encoding was default?

Anyways, maybe the best bet would be to modify this function with an encoding argument and default it to None, which is the default in the underlying functions being called:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darley-Wey @sea-bass