Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvements #21

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Speed improvements #21

wants to merge 1 commit into from

Conversation

bezumkin
Copy link

@bezumkin bezumkin commented Jul 1, 2013

I have over 1000 resources in the site map, which generated more than 6 seconds after each cleaning cache.

So, i made some speed improvements:

  • replaced xPDO::getCollection() on PDO::fetchAll()
  • added pre parse of item chunk by the new method makePlaceholders()

No functionality has been changed instead of better Tickets support. Now site map generates in 1.5 seconds.

Better Tickets support
@jpdevries
Copy link

Thanks, got this added over at the new location modxcms/GoogleSiteMap
modxcms@4ccac70

@bezumkin
Copy link
Author

bezumkin commented Oct 2, 2013

NIce!

During this time I have made my own version of sitemap snippet based on pdoTools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants