Skip to content

chore: remove support for .uccignore#1770

Merged
hetangmodi-crest merged 14 commits intoucc-6-0-0from
chore/remove-uccignore
Aug 20, 2025
Merged

chore: remove support for .uccignore#1770
hetangmodi-crest merged 14 commits intoucc-6-0-0from
chore/remove-uccignore

Conversation

@hetangmodi-crest
Copy link
Contributor

@hetangmodi-crest hetangmodi-crest commented May 29, 2025

Issue number: ADDON-76463

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Support for .uccignore has been removed. If a user includes this file, the build will now fail with an error message.

User experience

Users will no longer be able to use .uccignore feature.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review May 29, 2025 11:13
@hetangmodi-crest hetangmodi-crest requested review from a team as code owners May 29, 2025 11:13
@sgoral-splunk
Copy link
Contributor

Do we want to include this in the next major version?

@hetangmodi-crest hetangmodi-crest marked this pull request as draft June 25, 2025 09:27
@github-actions
Copy link

Code Coverage 🎉

Type PR Develop Change Status
Line Coverage 88.75% 88.21% 0.54% 🟢 Increased
Branch Coverage 82.87% 81.79% 1.08% 🟢 Increased

@hetangmodi-crest hetangmodi-crest changed the base branch from develop to ucc-6-0-0 August 11, 2025 09:14
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review August 11, 2025 10:29
@hetangmodi-crest hetangmodi-crest marked this pull request as draft August 14, 2025 12:48
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good lets jsut fix tests, plus i'm wondering if we should keep the uccignore documentation page or keep it only in whats new section, wdyt?

@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review August 19, 2025 09:41
@hetangmodi-crest
Copy link
Contributor Author

looks good lets jsut fix tests, plus i'm wondering if we should keep the uccignore documentation page or keep it only in whats new section, wdyt?

I think we've already added in the what's new section, and I'll remove this page as well from here.

Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hetangmodi-crest hetangmodi-crest merged commit dffdfb2 into ucc-6-0-0 Aug 20, 2025
79 checks passed
@hetangmodi-crest hetangmodi-crest deleted the chore/remove-uccignore branch August 20, 2025 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants