Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix github outputs #19

Merged
merged 1 commit into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/draft-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ jobs:
if: ${{ steps.prepare_release.outputs.NEEDS_UPDATE == 1 && steps.check_if_pr_open.outputs.NEEDS_PR == 1 }}
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
with:
commit-message: Prepare release v${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
title: "chore: Prepare release v${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}"
commit-message: Prepare chart release ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
title: "chore: Prepare chart release ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}"
body: |
Description
- Release chart version ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: |
changed=$(ct list-changed --config=ct.yaml)
if [[ -n "$changed" ]]; then
echo "::set-output name=changed::true"
echo "changed=true" >> "$GITHUB_OUTPUT"
fi

- name: Run chart-testing (lint)
Expand Down
8 changes: 4 additions & 4 deletions scripts/prepare-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ NEW_APP_VERSION=${APP_VERSION:-$LATEST_RUNNER_TAG}
if [ "$CURRENT_APP_VERSION" == "$NEW_APP_VERSION" ]; then
echo "Runner image tag is already up to date (appVersion $CURRENT_APP_VERSION)."
if [[ -n "${GITHUB_ACTIONS-}" ]]; then
echo "NEEDS_UPDATE=0" >> "$GITHUB_ENV"
echo "NEEDS_UPDATE=0" >> "$GITHUB_OUTPUT"
fi
exit 0
else
echo "Runner image tag is not up to date. Current appVersion is $CURRENT_APP_VERSION and the new appVersion is $NEW_APP_VERSION."
if [[ -n "${GITHUB_ACTIONS-}" ]]; then
echo "NEEDS_UPDATE=1" >> "$GITHUB_ENV"
echo "NEW_APP_VERSION=$NEW_APP_VERSION" >> "$GITHUB_ENV"
echo "NEEDS_UPDATE=1" >> "$GITHUB_OUTPUT"
echo "NEW_APP_VERSION=$NEW_APP_VERSION" >> "$GITHUB_OUTPUT"
fi
fi

Expand All @@ -52,5 +52,5 @@ echo "Updating the chart version to $NEW_CHART_VERSION"
NEW_CHART_VERSION=${NEW_CHART_VERSION} yq eval -i '.version = strenv(NEW_CHART_VERSION)' ${CHART_YAML_PATH}

if [[ -n "${GITHUB_ACTIONS-}" ]]; then
echo "NEW_CHART_VERSION=$NEW_CHART_VERSION" >> "$GITHUB_ENV"
echo "NEW_CHART_VERSION=$NEW_CHART_VERSION" >> "$GITHUB_OUTPUT"
fi