Skip to content

Only call size once per data provider #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Oct 29, 2024

No description provided.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (2c7db77) to head (b6ede76).
Report is 155 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2032      +/-   ##
============================================
+ Coverage     80.44%   81.84%   +1.39%     
- Complexity     4337     4609     +272     
============================================
  Files           441      448       +7     
  Lines         13534    14445     +911     
  Branches       1707     1827     +120     
============================================
+ Hits          10888    11822     +934     
+ Misses         2008     1946      -62     
- Partials        638      677      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vampire Vampire force-pushed the call-size-only-once branch 4 times, most recently from a8ef8b8 to 908e1b1 Compare November 2, 2024 02:07
@Vampire Vampire force-pushed the call-size-only-once branch 2 times, most recently from bf40156 to 18aaea5 Compare November 4, 2024 03:38
@Vampire Vampire requested a review from AndreasTu November 4, 2024 03:43
AndreasTu
AndreasTu previously approved these changes Nov 4, 2024
Copy link
Member

@AndreasTu AndreasTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

AndreasTu
AndreasTu previously approved these changes Nov 4, 2024
@Vampire Vampire force-pushed the call-size-only-once branch from 0e169d0 to 62efeaa Compare November 4, 2024 13:57
@Vampire
Copy link
Member Author

Vampire commented Nov 4, 2024

Argh, damn codecov.
Now that I change less lines, it doesn't like the null case not being tested.
Strange actually because when doing the changes it definitely was null at some point which is why I added the null case. :-/

@Vampire
Copy link
Member Author

Vampire commented Nov 4, 2024

I was not able to reproduce the case with the current code, maybe it was in some intermediate state.
I also from a cursory look do not see how it should be able to happen.
So a hopefully last review please. :-)

@Vampire Vampire requested a review from AndreasTu November 4, 2024 16:43
@Vampire Vampire merged commit d6f8372 into spockframework:master Nov 5, 2024
25 checks passed
@Vampire Vampire deleted the call-size-only-once branch November 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants