-
Notifications
You must be signed in to change notification settings - Fork 473
Only call size once per data provider #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36efd17
to
cfd9e0f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2032 +/- ##
============================================
+ Coverage 80.44% 81.84% +1.39%
- Complexity 4337 4609 +272
============================================
Files 441 448 +7
Lines 13534 14445 +911
Branches 1707 1827 +120
============================================
+ Hits 10888 11822 +934
+ Misses 2008 1946 -62
- Partials 638 677 +39 ☔ View full report in Codecov by Sentry. |
a8ef8b8
to
908e1b1
Compare
spock-core/src/main/java/org/spockframework/runtime/DataIteratorFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/runtime/DataIteratorFactory.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/runtime/DataIteratorFactory.java
Outdated
Show resolved
Hide resolved
bf40156
to
18aaea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
18aaea5
to
1bb5246
Compare
1bb5246
to
0e169d0
Compare
0e169d0
to
62efeaa
Compare
Argh, damn codecov. |
62efeaa
to
b6ede76
Compare
I was not able to reproduce the case with the current code, maybe it was in some intermediate state. |
No description provided.