Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jmh: Micro bench marks for BloomFilter #1913

Merged
merged 1 commit into from
May 9, 2019

Conversation

anish749
Copy link
Contributor

@anish749 anish749 commented May 9, 2019

I was using this code for benchmarking the bloom filter from #1806 on sbt shell. I think it would nice to have them here, if we need to revisit this later.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1913 into master will decrease coverage by 1.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1913     +/-   ##
=========================================
- Coverage   72.57%   70.88%   -1.7%     
=========================================
  Files         200      200             
  Lines        6312     6312             
  Branches      347      452    +105     
=========================================
- Hits         4581     4474    -107     
- Misses       1731     1838    +107
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50% <0%> (-50%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.82% <0%> (-47.11%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 41.17% <0%> (-29.42%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 62.96% <0%> (-18.52%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 40% <0%> (-17.5%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 1.76% <0%> (-16.82%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 57.89% <0%> (-15.79%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 28.94% <0%> (-10.53%) ⬇️
...y/scio/values/PairSkewedSCollectionFunctions.scala 91.93% <0%> (-3.23%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 24.66% <0%> (-2.67%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60b312...d5fe8ea. Read the comment docs.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition! Thx @anish749

@regadas regadas merged commit 3619202 into spotify:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants