Skip to content

Bugfix for Spree 3.7 on Rails 5 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bugfix for Spree 3.7 on Rails 5 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e65e06
[BUGFIX] fix undefined method :back in comments_controller redirect
johndavid400 May 28, 2019
472fdf2
fix typo in comment
johndavid400 May 28, 2019
2f4f2a9
only show admin comment menu item if admin
johndavid400 Sep 17, 2019
6b04a83
Merge branch 'master' of github.com:johndavid400/spree_comments
johndavid400 Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/controllers/spree/admin/comments_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
class Spree::Admin::CommentsController < Spree::Admin::ResourceController
private

def location_after_save
:back
# :back is deprecated in Rails 5, but request.referrer should also work as intended on older versions (confirmed to work on Rails 4 and 5)
request.referrer
end
end

end
4 changes: 2 additions & 2 deletions app/overrides/add_comment_configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Deface::Override.new(:virtual_path => "spree/admin/shared/sub_menu/_configuration",
:name => "converted_admin_configurations_menu_468573024",
:insert_bottom => "[data-hook='admin_configurations_sidebar_menu']",
:text => "<%= configurations_sidebar_menu_item Spree.t(:comment_types), admin_comment_types_path %>",
:disabled => false)
:text => "<%- if spree_current_user.admin? %><%= configurations_sidebar_menu_item Spree.t(:comment_types), admin_comment_types_path %><% end %>",
:disabled => false)