Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONEUP-7762: Fix resize behavior #38

Merged
merged 10 commits into from
Jan 2, 2024
Merged

ONEUP-7762: Fix resize behavior #38

merged 10 commits into from
Jan 2, 2024

Conversation

aramin
Copy link
Contributor

@aramin aramin commented Dec 29, 2023 •
edited
Loading

What

  • Fix resize behavior by checking if the page has a different size than before.

Why

cudle
cudle approved these changes Dec 29, 2023
View reviewed changes
Copy link

@cudle cudle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@aramin aramin force-pushed the fix/ONEUP-7762__sticky-video-scrolling-bug branch from f15fbe2 to 9bd05c2 Compare January 2, 2024 14:32
@aramin aramin force-pushed the fix/ONEUP-7762__sticky-video-scrolling-bug branch from 9bd05c2 to f68603f Compare January 2, 2024 14:45
@aramin aramin force-pushed the fix/ONEUP-7762__sticky-video-scrolling-bug branch from f68603f to 5cde5f4 Compare January 2, 2024 14:49
@aramin aramin requested a review from cudle January 2, 2024 15:51
@aramin aramin merged commit bfb68e9 into master Jan 2, 2024
2 checks passed
@aramin aramin deleted the fix/ONEUP-7762__sticky-video-scrolling-bug branch January 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebastian-Fitzner Sebastian-Fitzner Awaiting requested review from Sebastian-Fitzner

@moegelin moegelin Awaiting requested review from moegelin

@cudle cudle Awaiting requested review from cudle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramin @cudle