Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ocp maps/refactor naming #9

Merged
merged 5 commits into from
Sep 18, 2024
Merged

fix: Ocp maps/refactor naming #9

merged 5 commits into from
Sep 18, 2024

Conversation

as-extern-mbertram
Copy link
Collaborator

Change from input variable to local for naming AZ IDs

@as-extern-mbertram as-extern-mbertram marked this pull request as ready for review September 18, 2024 14:48
@as-extern-mbertram as-extern-mbertram changed the title Ocp maps/refactor naming fix: Ocp maps/refactor naming Sep 18, 2024
plcoelho
plcoelho approved these changes Sep 18, 2024
View reviewed changes
Copy link

@plcoelho plcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, feel free to merge.

@as-extern-mbertram as-extern-mbertram merged commit ef5021e into ocp-maps-main Sep 18, 2024
2 of 3 checks passed
@as-extern-mbertram as-extern-mbertram deleted the ocp-maps/refactor-naming branch September 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plcoelho plcoelho plcoelho approved these changes

@gentgme gentgme Awaiting requested review from gentgme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@as-extern-mbertram @plcoelho