Skip to content

Make BeanOutputConverter more extensible #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markpollack
Copy link
Member

Summary

  • Makes BeanOutputConverter class more subclass-friendly by changing access modifiers for key fields and methods
  • Extracts template string in getFormat() to allow customization by subclasses
  • Provides better extension points for customizing behavior

Fixes #1985

@markpollack markpollack force-pushed the 1985-bean-output-converter branch from 825f14a to 34d5f9c Compare April 17, 2025 19:47
This change improves the extensibility of BeanOutputConverter by:
- Making generateSchema method and jsonSchema field protected
- Making logger and type fields protected for subclass access
- Extracting format template into a separate protected method

These changes allow subclasses to access and override key parts
of the converter's behavior without having to reimplement large
portions of the class.

Fixes #1985

Signed-off-by: Mark Pollack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for BeanOutputConverter with non-standard enum mapping
1 participant