Optimise CassandraChatMemoryRepository for MessageWindowChatMemory usage pattern #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
force-pushed
the
mck/CassandraChatMemoryRepository_0
branch
2 times, most recently
from
af0c80d to
a5649da
Compare
…age pattern Time-series each chat window in Cassandra, keeping past (and deleted) windows still in the db. Add ability to store different MessageTypes. Signed-off-by: mck <[email protected]>
michaelsembwever
force-pushed
the
mck/CassandraChatMemoryRepository_0
branch
from
a5649da to
73e31d1
Compare
| stmt = stmt.whereColumn(columnName).isEqualTo(QueryBuilder.bindMarker(columnName)); | ||
| private Message getMessage(UdtValue udt) { | ||
| String content = udt.getString(this.conf.messageUdtContentColumn); | ||
| Map<String, Object> props = Map.of(CONVERSATION_TS, udt.getInstant(this.conf.messageUdtTimestampColumn)); |
There was a problem hiding this comment.
@ZYMCao messages have the timestamp value in their metadata, as an Instant instance, under the CONVERSATION_TS key.
The literal for that key is found here: https://github.com/spring-projects/spring-ai/blob/main/memory/spring-ai-model-chat-memory-cassandra/src/main/java/org/springframework/ai/chat/memory/cassandra/CassandraChatMemoryRepository.java#L50-L51
|
@michaelsembwever Thanks for the PR! Rebased and merged as 87b680a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time-series each chat window in Cassandra, keeping past (and deleted) windows still in the db. Add ability to store different MessageTypes.
ref: #2998