Enable auto complete for 'spring.ai.vertex.ai.gemini.chat.options' #3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
39
to
40
| * | ||
| * @author Hyunsang Han |
There was a problem hiding this comment.
Suggested change
| * | |
| * @author Hyunsang Han |
There was a problem hiding this comment.
Please move the @author tag to the class level.
* @author Christian Tzolov
* @author Hyunsang Han
* @since 0.8.0
*/
@ConfigurationProperties(VertexAiGeminiChatProperties.CONFIG_PREFIX)
public class VertexAiGeminiChatProperties {There was a problem hiding this comment.
Oh, I missed it. Thanks!
| @@ -35,7 +36,10 @@ public class VertexAiGeminiChatProperties { | |||
|
|
|||
| /** | |||
| * Vertex AI Gemini API generative options. | |||
| * | |||
| * @author Hyunsang Han | |||
There was a problem hiding this comment.
The @author tag should be used on the class itself instead of the specific method. Could you move this there (line 28)? Thanks!
Signed-off-by: Hyunsang Han <[email protected]>
ThomasVitale
approved these changes
May 12, 2025
dev-jonghoonpark
approved these changes
May 12, 2025
|
@HyunSangHan Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spring.ai.vertex.ai.gemini.chat.options.*were not configured to support auto-completion in configuration files.After adding this annotation, building the project triggers the Spring Boot configuration metadata processor to handle the
@NestedConfigurationPropertyannotation and generate the necessary metadata for auto-completion.I tested this locally, and I was able to confirm that the generated metadata file includes the
spring.ai.vertex.ai.gemini.chat.options.*properties.Closes #3079