add similarity threshold capability to VectorStoreChatMemoryAdvisor #3454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…visor Signed-off-by: Peter Keeler <[email protected]>
scionaltera
changed the title
YunKuiLu
reviewed
Jun 6, 2025
| Assert.notNull(systemPromptTemplate, "systemPromptTemplate cannot be null"); | ||
| Assert.isTrue(defaultTopK > 0, "topK must be greater than 0"); | ||
| Assert.isTrue(defaultSimilarityThreshold >= 0, "similarityThreshold must be equal to or greater than 0"); |
There was a problem hiding this comment.
According to the assertion of methodorg.springframework.ai.vectorstore.SearchRequest.Builder#similarityThreshold.
The defaultSimilarityThreshold should be defaultSimilarityThreshold >= 0 && defaultSimilarityThreshold <= 1
Suggested change
| Assert.isTrue(defaultSimilarityThreshold >= 0, "similarityThreshold must be equal to or greater than 0"); | |
| Assert.isTrue(defaultSimilarityThreshold >= 0 && defaultSimilarityThreshold <= 1, "similarityThreshold must be in [0,1] range"); |
| * retrieve | ||
| * @return this builder | ||
| */ | ||
| public Builder defaultSimilarityThreshold(Double defaultSimilarityThreshold) { |
There was a problem hiding this comment.
Maybe we don't need to use the Double wrapper class here?
| @@ -221,6 +237,8 @@ public static class Builder { | |||
|
|
|||
| private Integer defaultTopK = DEFAULT_TOP_K; | |||
|
|
|||
| private Double defaultSimilarityThreshold = DEFAULT_SIMILARITY_THRESHOLD; | |||
Sure thing. I've been sick the past couple of days but I can get these changes in soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This advisor did not have support for setting the similarity threshold, so it defaulted to returning every document regardless of similarity. In a conversation where the user has changed to a different topic the result was returning a bunch of documents with no relevance to the user's latest input.
I experimented with setting a value greater than 0 and liked the results because it would begin to include results more relevant to the conversation. I thought it would be nice to contribute the change back.
I left the default at 0 so as not to change the earlier behavior.