GH-10083: Implement Nullability in XML module #10161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 * Add @org.jspecify.annotations.NullMarked to all the packages in the XML module * Apply JSpecify null safety annotation improvements Signed-off-by: Eddie Cho <[email protected]>
artembilan
requested changes
Jun 24, 2025
| @@ -230,6 +233,7 @@ protected void onInit() { | |||
| this.evaluationContext = ExpressionUtils.createStandardEvaluationContext(getBeanFactory()); | |||
| if (this.templates == null) { | |||
There was a problem hiding this comment.
You marked it as @SuppressWarnings("NullAway.Init"), and I understand why.
But doesn't this if complain that the property is never null?
Thanks
There was a problem hiding this comment.
Yeah, looks like that work.
Just did something similar in Zip module: e21d843#diff-9f1c53dcaacbf6eb4a502eeb67a286da470aabb2b9401c05c50f5bc0788fa76dR64
And only what I see is a complain from my IntelliJ IDEA.
JSpecify compiler plugin is good with that.
So, merging your contribution as is.
Thank you!
artembilan
added
type: refactoring
in: xml
type: enhancement
and removed
type: refactoring
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083