Revise MBeanExporterHelper reflection logic
#10178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed reflection logic when getting `channelNames` from bean `$autoCreateChannelCandidates` in favor of `ChannelInitializer.AutoCreateCandidatesCollector.channelNames()` Fixes: spring-projects#10167 Signed-off-by: Jiandong Ma <[email protected]>
artembilan
requested changes
Jun 30, 2025
There was a problem hiding this comment.
@cppwfs ,
When this is good and ready to be merged, the Auto-cherry-pick to 6.5.x & 6.4.x will do the trick to back-port it.
Double check, please , if proper Fixes: is there in the commit message .
thank you both in advance!
...ration-jmx/src/main/java/org/springframework/integration/jmx/config/MBeanExporterHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
cppwfs
approved these changes
Jun 30, 2025
|
Thank you, I saw changes are in main, so close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed reflection logic when getting
channelNamesfrom bean$autoCreateChannelCandidatesin favor ofChannelInitializer.AutoCreateCandidatesCollector.channelNames()Fixes: #10167