Add JSpecify nullify to channel/interceptor, code, and codec/kryo packages #10187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kages * Missed the channel/interceptor on the last PR. * Removed CompositeCodec(Codec defaultCodec) because null can never be pass to the Codec. In the past it would have thrown a NPE. Continued effort or issue: spring-projects#10083
mrpiggi
reviewed
Jul 2, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Show resolved
Hide resolved
artembilan
requested changes
Jul 2, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Show resolved
Hide resolved
artembilan
requested changes
Jul 2, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
Removed @nullable from delegates field in CompositeCodec Remove check for null for delegate and replace it with isEmpty
artembilan
requested changes
Jul 2, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
|
@artembilan So you obviously voted against my suggestion regarding |
No, I did not voted against you. Feel free to raise a PR with whatever improvements you see! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued effort or issue: #10083