Restore class-decorator overload annotation for freeze_time #574
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this just about avoiding a warning on MyPy for Python 3.13? The problem is, this breaks Pytype, it no longer knows that the decorated class has the same type. |
This was removed in f9235ae without explanation, possibly because mypy objects to the overlap under Python 3.13. But Pytype needs that to infer that the type is unchanged when a class is decorated with `@freezegun.freeze_time` (unlike mypy, which assumes class decorators, unlike function decorators, always leave the type unchanged).
sfreilich
force-pushed
the
restore-class-decorator-overload
branch
from
e1c6c98 to
1df6623
Compare
|
I think the right thing to do is to put that back and suppress the warning in mypy (which I believe still gets the inference correct on both class and method decorators, even with the extra annotation). I've updated the change to do that. |
bblommers
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
Thanks for the PR @sfreilich - this does make sense. Thanks for adding an explanation as well, that should avoid us from making the same mistake again 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in f9235ae, apparently inadvertently.