Skip to content

PR: Add utility functions that convert between ints and Qt Enums (compat.py) #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dalthviz merged 2 commits into from
Nov 19, 2025
Merged

PR: Add utility functions that convert between ints and Qt Enums (compat.py) #481

dalthviz merged 2 commits into from
Nov 19, 2025

Conversation

@zjp
Copy link
Contributor

@zjp zjp commented Apr 19, 2024 •
edited by dalthviz
Loading

This PR implements the functions I asked about in #356

Edit:

Fixes #356

@zjp
Copy link
Contributor Author

zjp commented Apr 19, 2024

I can see some failures on PySide2 that I'll address when I get to a machine that has a binary PySide2 available (I usually work on an arm64 mac).

@dalthviz dalthviz added this to the v2.5.0 milestone Apr 25, 2024
@dalthviz dalthviz linked an issue Apr 25, 2024 that may be closed by this pull request
Is there a need for enumasint or intasenum? #356
Closed
@coveralls
Copy link

coveralls commented Jul 20, 2024 •
edited
Loading

Coverage Status

coverage: 88.546%. remained the same
when pulling 439658c on zjp:int_as_enum
into 03f38d2 on spyder-ide:master.

@zjp zjp force-pushed the int_as_enum branch 4 times, most recently from fef4bda to 2dd8d02 Compare July 21, 2024 00:45
@zjp
Copy link
Contributor Author

zjp commented Jul 21, 2024

Sorry it's taken me so long to update this PR. It looks like the last remaining failure is in PyQt5 on Python 3.7/Windows/Conda. The version in the runner is 5.9.2, but the last version available on Conda for that platform/tool combination is 5.15.7 so it would be possible to use almost the same version as the non-Conda version (5.15.10). Let me know your thoughts.

@zjp
Copy link
Contributor Author

zjp commented Jul 21, 2024

I found a workaround.

@dalthviz dalthviz changed the title compat.py: Add utility functions that convert between ints and Qt Enums PR: Add utility functions that convert between ints and Qt Enums (compat.py) Aug 21, 2024
@dalthviz dalthviz modified the milestones: v2.6.0, v2.5.0 Nov 10, 2025
@dalthviz
Copy link
Member

dalthviz commented Nov 18, 2025

Hi and sorry for let this stale for such a long time @zjp ! Could it be possible for you to rebase this on top of latest master so we can have a fresh CI run and merge this? I think I will try to update any pending PR for 2.5.0 tomorrow but please let us know if you prefer to do the rebase/update yourself!

@dalthviz dalthviz mentioned this pull request Nov 18, 2025
Merged
@zjp
Copy link
Contributor Author

zjp commented Nov 19, 2025

No problem! Glad to see some movement.

dalthviz
dalthviz approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zjp !

@dalthviz dalthviz merged commit 83ecde3 into spyder-ide:master Nov 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalthviz dalthviz dalthviz approved these changes

Assignees

@zjp zjp

Labels

type:Enhancement

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

Is there a need for enumasint or intasenum?

3 participants

@zjp @coveralls @dalthviz