Skip to content

Conversation

@ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 added this to the v2.5.0 milestone Nov 14, 2025
@ccordoba12 ccordoba12 self-assigned this Nov 14, 2025
@ccordoba12 ccordoba12 marked this pull request as draft November 14, 2025 17:09
@coveralls
Copy link

coveralls commented Nov 14, 2025

Coverage Status

coverage: 88.546% (-0.5%) from 89.053%
when pulling 5a7b7b1 on ccordoba12:promote-more-enums
into 4defc52 on spyder-ide:master.

@ccordoba12 ccordoba12 force-pushed the promote-more-enums branch 7 times, most recently from 3822d20 to f2b0d91 Compare November 17, 2025 17:23
@ccordoba12 ccordoba12 changed the title [WIP] PR: Promote unscoped enums in many other modules for PyQt6 compatibility PR: Promote unscoped enums in many other modules for PyQt6 compatibility Nov 17, 2025
@ccordoba12 ccordoba12 marked this pull request as ready for review November 17, 2025 17:41
@ccordoba12 ccordoba12 requested a review from dalthviz November 17, 2025 17:43
@ccordoba12
Copy link
Member Author

@dalthviz, this is ready for review. I promoted enums for modules with attributes listed in the enums.txt file available in qutebrowser/qutebrowser#5904 (comment).

I think it's important to promote enums wherever they are available since we're already supporting them but only for a few modules (like QtGui and QtWidgets).

@dalthviz
Copy link
Member

Thanks @ccordoba12 ! I haven't checked the PR in detail but could it make sense to merge first #523 to check no test fails with Qt 6.8 bindings here?

@ccordoba12
Copy link
Member Author

Sure, no problem.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 !

@dalthviz dalthviz merged commit 03f38d2 into spyder-ide:master Nov 18, 2025
19 checks passed
@ccordoba12 ccordoba12 deleted the promote-more-enums branch November 18, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants