Skip to content

PR: Disable fullscreen mode when running on WSL (Layout) #24009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

jsbautista
Copy link
Collaborator

Description of Changes

Fix in Fullscreen Mode child windows are hidden and have no mouse control in WSL.
A method was added to detect if the system is running on WSL, and it was used to disable the fullscreen mode option in case the system is running on WSL.

Issue(s) Resolved

Fixes #22736

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for you @jsbautista, the rest looks good to me.

@ccordoba12 ccordoba12 changed the title PR: fix fullscreen mode in case the system is running on WSL PR: Disable fullscreen mode when running on WSL (Layout) Mar 21, 2025
@ccordoba12 ccordoba12 added this to the v6.0.6 milestone Mar 21, 2025
@ccordoba12 ccordoba12 requested a review from dalthviz March 23, 2025 22:43
@ccordoba12
Copy link
Member

@dalthviz, please check manually if this disables fullscreen mode for you on WSL (not urgent though because it's for 6.0.6).

@ccordoba12
Copy link
Member

@dalthviz, gentle reminder for you to test this PR when you have some time. Thanks!

@dalthviz
Copy link
Member

dalthviz commented Apr 1, 2025

Gave this a check locally and seems like the validation is working 👍 (the action to enter fullscreen mode is deactivated when launching Spyder from WSL):

image

@dalthviz
Copy link
Member

dalthviz commented Apr 1, 2025

/show binder

Copy link

github-actions bot commented Apr 1, 2025

Binder 👈 Launch a Binder instance on this branch

@ccordoba12
Copy link
Member

Thanks @dalthviz for checking!

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @jsbautista!

@ccordoba12 ccordoba12 merged commit 1751de3 into spyder-ide:master Apr 2, 2025
20 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

Copy link

lumberbot-app bot commented Apr 2, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1751de3dd663862fa2d7e3e62a1b61ba4faa673d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24009: PR: Disable fullscreen mode when running on WSL (Layout)'
  1. Push to a named branch:
git push YOURFORK 6.x:auto-backport-of-pr-24009-on-6.x
  1. Create a PR against branch 6.x, I would have named this PR:

"Backport PR #24009 on branch 6.x (PR: Disable fullscreen mode when running on WSL (Layout))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Fullscreen Mode child windows are hidden and have no mouse control in WSL
3 participants