-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PR: Disable fullscreen mode when running on WSL (Layout) #24009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions for you @jsbautista, the rest looks good to me.
Co-authored-by: Carlos Cordoba <[email protected]>
@dalthviz, please check manually if this disables fullscreen mode for you on WSL (not urgent though because it's for 6.0.6). |
@dalthviz, gentle reminder for you to test this PR when you have some time. Thanks! |
/show binder |
Thanks @dalthviz for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @jsbautista!
@meeseeksdev please backport to 6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…g on WSL (Layout)
…nning on WSL (Layout)) (#24127) Co-authored-by: jsbautista <[email protected]>
Description of Changes
Fix in Fullscreen Mode child windows are hidden and have no mouse control in WSL.
A method was added to detect if the system is running on WSL, and it was used to disable the fullscreen mode option in case the system is running on WSL.
Issue(s) Resolved
Fixes #22736
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista