ENH: Add support for PySide6 6.9+#25422
Draft
larsoner wants to merge 4 commits intospyder-ide:masterfrom
Draft
Conversation
Contributor
Author
|
I also see with a slightly better (but still incomplete!) regex: so there are some other candidates to move |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #24825 (comment) I:
Q*subclasses to last positionif not PYSIDE2toif not (PYSIDE2 or PYSIDE6)conditionals__init__calls for those ☝️This at least gets me to a window that opens and interacts:
The TODO I think would be:
if not (PYSIDE2 or PYSIDE6):conditionals call all super class initsQ*classes are at the end (I did things likegit grep "QObject, "but this is incomplete)sig.emitcalls (they cause a segfault)cc @rear1019 in case you want to test and/or contribute. I'm also happy if @ccordoba12 or someone else wants to take over
Closes #20201