Fix undeclared variables in nested list comprehension with strict_undefined #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2025 13:13
Visit target variable in list and dictionary comprehensions
sqla-tester
reviewed
Apr 10, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 0b64e72 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 0b64e72: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5861 |
|
ok great let's try it out |
|
a hole in one! nice job |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5861 has been merged. Congratulations! :) |
artdogma
added a commit
to artdogma/pymako
that referenced
this pull request
Aug 27, 2025
…efined Fix undefined variable errors when ``strict_undefined=True`` when using a nested list comprehension. Pull request courtesy Sébastien Granjoux. Fixes: #418 Closes: #419 Pull-request: sqlalchemy/mako#419 Pull-request-sha: 0b64e72f92ec8b09cccf91d011bd0680969b115e Change-Id: I13f6296ffe1f5f0d5f68b7da07ff76bbac7668e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the issue #418.