Fixes Mac Console / Delegate Glitch #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So Avalonia registers their own App Delegate on MacOSX
See: https://github.com/AvaloniaUI/Avalonia/blob/5a2ef35dacbce0438b66d9f012e5f629045beb3d/native/Avalonia.Native/src/OSX/app.mm#L7-L23
In our application we register our own which cases Avalonia's to get removed
SQRLDotNetClient/SQRLDotNetClientUI/App.xaml.cs
Line 82 in b2463a0
This causes the Avalonia registered events
To no be executed which causes our application to not be activated with the right options.
This fix basically re-implements the Avalonia events in our own AppDelegate (I just re-wrote their code in C# inside our app delegate)
This appears to fix the issue and may prevent other issues we aren't yet aware of.
I also opened this Issue with Avalonia: AvaloniaUI/Avalonia#3822 as an enhancement request.
It would be nice to be able to subscribe to all these events directly without having to re-implement the AppDelegate completely seeing as if they (Avalonia) changes or updates their delegate code our app won't benefit from that with this solution.
Either way it appears to work fine now
Also change the mac and linux installers to tar.gz #143