Skip to content

Remove ksp/shadedUtil.kt #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ksp/shadedUtil.kt #1875

wants to merge 1 commit into from

Conversation

ting-yuan
Copy link

and use KSP's implementation.

and use KSP's implementation.
@ZacSweers
Copy link
Collaborator

We're reluctant to ship unshaded experimental KSP APIs since they could break again. Could these be promoted to stable instead?

@ting-yuan
Copy link
Author

A large part of those are actually meant for JVM and we haven't have time to (find the best way to) make them JVM only. The earliest date I can think of to work on this is near the end of this year, though. Short term solutions can be updating shadedUtil.kt or making it a wrapper where the experimental annotations are contained.

@JakeWharton
Copy link
Collaborator

The problem is the lack of ABI compatibility. We can't use it at all. But updating sounds like the right short-term solution.

@Tolriq
Copy link
Contributor

Tolriq commented Nov 8, 2024

With Kotlin 2.1 approaching and KSP1 deprecation, is there any decision made about this?

Except issues if there's new breaking change on ksp side, is there any risks to apply this on a fork?

@Jean-Daniel
Copy link

Is there any plan to merge this change ? @JsonQualifier are still unusable with KSP 2 without it.

Tolriq added a commit to Tolriq/moshi that referenced this pull request Apr 15, 2025
@Brock-Gibson
Copy link

Any update on this, would love to be able to KSP2.

@Tolriq
Copy link
Contributor

Tolriq commented May 12, 2025

Just fork and merge this, it works nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants