vultr: fix empty port range parsing (#39)

squat · Jun 1, 2018 · bcf9459 · bcf9459
1 parent 237b7f7
commit bcf9459
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/vultr/resource_firewall_rule.go b/vultr/resource_firewall_rule.go
@@ -177,6 +177,9 @@ func splitFirewallRule(portRange string) (int, int, error) {
 		return 0, 0, nil
 	}
 	ports := strings.Split(portRange, "-")
+	if len(strings.TrimSpace(ports[0])) == 0 {
+		return 0, 0, nil
+	}
 	from, err := strconv.Atoi(strings.TrimSpace(ports[0]))
 	if err != nil {
 		return 0, 0, err

diff --git a/vultr/resource_firewall_rule_test.go b/vultr/resource_firewall_rule_test.go
@@ -27,7 +27,7 @@ func TestSplitFirewallRule(t *testing.T) {
 			portRange: "-",
 			from:      0,
 			to:        0,
-			err:       true,
+			err:       false,
 		},
 		{
 			portRange: "22",