Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph drawio: Pull strategy and Interactive mode support #2291

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

FloSch62
Copy link
Member

This PR introduces two major improvements to the clab-io-draw functionality:

  1. Automatic Image Updates
  • When using the latest tag, containerlab now automatically checks and pulls
    the newest version of clab-io-draw
  • Users are informed about the update status through clear log messages
  • Ensures users always have the most recent version when using latest tag
  1. Native Interactive Mode Support
  • Adds native support for the -I (interactive) mode directly in containerlab
  • Users can now utilize the interactive
# Start interactive cli ui
containerlab graph -t st.clab.yml --drawio --drawio-args="-I --theme nokia_modern_dark"

@FloSch62 FloSch62 requested a review from hellt November 12, 2024 13:06
@steiler
Copy link
Collaborator

steiler commented Nov 12, 2024

Can't we use the docker lib instead of the execs?

@FloSch62
Copy link
Member Author

FloSch62 commented Nov 12, 2024

@steiler the origin of the execs is from @hellt

It think I tried the docker lib once but I was failing to get it work. If you want to move it to the docker lib, feel free to do it ;)

@hellt hellt merged commit 14bcb1d into main Nov 12, 2024
66 checks passed
@hellt hellt deleted the drawio_graph_image_pull branch November 12, 2024 18:23
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 51.42%. Comparing base (af637ce) to head (9d40892).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
clab/graph.go 35.71% 32 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   51.17%   51.42%   +0.24%     
==========================================
  Files         172      172              
  Lines       16708    16758      +50     
==========================================
+ Hits         8551     8617      +66     
+ Misses       7243     7219      -24     
- Partials      914      922       +8     
Files with missing lines Coverage Δ
clab/graph.go 14.49% <35.71%> (+14.49%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants