Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing ~/.docker/config.json logged as a debug #2293

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

hyposcaler-bot
Copy link
Contributor

addresses issue #2283

runtime/docker/auth.go Outdated Show resolved Hide resolved
@hyposcaler-bot
Copy link
Contributor Author

hyposcaler-bot commented Nov 13, 2024

@hellt see the new commit, I think this does what you're looking for. if os.ReadFile returns os.ErrNotExist we log the missing file as debug, any other error reported should be logged info. I don't really have a good way to test the second half of that.

@hellt hellt merged commit 978f006 into srl-labs:main Nov 14, 2024
66 checks passed
@hellt
Copy link
Member

hellt commented Nov 14, 2024

Thanks!

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.41%. Comparing base (7bd4f03) to head (38c3675).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
runtime/docker/auth.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   51.38%   51.41%   +0.02%     
==========================================
  Files         172      172              
  Lines       16758    16761       +3     
==========================================
+ Hits         8611     8617       +6     
+ Misses       7224     7222       -2     
+ Partials      923      922       -1     
Files with missing lines Coverage Δ
runtime/docker/auth.go 75.00% <0.00%> (-2.93%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants