Skip to content

🐛 Append variable name to constant in from_numpy #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

hayesall
Copy link
Member

For example: If "variable 1" takes value "0", then the created
fact will be:

v1(id1,v1_0).

This should make it more likely that the unique variable
names assumption is not violated.

See also

For example: If "variable 1" takes value "0", then the created
fact will be:

```
v1(id1,v1_0).
```

This *should* make it more likely that the unique variable
names assumption is not violated.
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #25 (3f61022) into main (b1e7bf0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          10       10           
  Lines         207      207           
=======================================
  Hits          193      193           
  Misses         14       14           
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
relational_datasets/convert/convert_numpy.py 94.87% <100.00%> (ø)
...ional_datasets/convert/tests/test_convert_numpy.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e7bf0...3f61022. Read the comment docs.

@hayesall hayesall merged commit 254d6ef into main Jun 20, 2022
@hayesall hayesall deleted the unique-variable-names branch June 20, 2022 20:29
hayesall added a commit that referenced this pull request Jun 20, 2022
Basically, this re-runs the three documentation notebooks to reflect
the changes introduced in #25

This also adds a note regarding the `.astype(int)` calls
in `01_converting_propositional_datasets.ipynb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant