Enhance ttfont to use an existing Font::TTF::Font object. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A couple of use cases:
|
ssimms
reviewed
May 26, 2025
lib/PDF/API2.pm
Outdated
Comment on lines
1949
to
1950
| Setting format to C<truetype> is mandatory if the C<$name> argument is a | ||
| C<Font::TTF::Font> object. |
Owner
There was a problem hiding this comment.
Can you remove this requirement? It seems like this is something that can be inferred.
…F::Font object to the font method.
ssimms
added a commit
that referenced
this pull request
Jul 2, 2025
ssimms
added a commit
that referenced
this pull request
Aug 29, 2025
- [GH-85] Fix default_page_size when called without arguments (patch by Johan Vromans). - [GH-90] Fix deprecated option -noembed (reported by Bernhard Schmalhofer). - [GH-91] Support annotation links to a named external destination (patch by Johan Vromans). - [GH-92] Allow Font::TTF::Font objects to be used as fonts (patch by Johan Vromans).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple patch enhances
fontto take an existingFont::TTF::Fontobject instead of a file name. This is useful in cases you aready have such an object, e.g. manually created, or derived from other sources.The relevant code changes are in
lib/PDF/API2/Resource/CIDFont/TrueType/FontFile.pm. The other changes are to propagate the functionality to thettfontandfontfunctions. And documentation.