Open
Conversation
# Conflicts: # pystac/extensions/mlm.py
# Conflicts: # CHANGELOG.md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 92.31% 92.44% +0.13%
==========================================
Files 55 55
Lines 8403 8604 +201
Branches 973 1045 +72
==========================================
+ Hits 7757 7954 +197
- Misses 458 459 +1
- Partials 188 191 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
pinging @romeokienzler for a code review |
|
@jonas-hurst I'm in for the review - let me take a look! |
gadomski
reviewed
Dec 5, 2025
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
One minor question, but otherwise LGTM.
| @property | ||
| def mlm(self) -> AssetGeneralMLMExtension[Asset] | AssetDetailedMLMExtension: | ||
| if "mlm:name" in self.stac_object.extra_fields: | ||
| if "mlm:architecture" in self.stac_object.extra_fields: |
Member
There was a problem hiding this comment.
What's the reason for this change? It's not clear to me from reading the extension description why the presence of this field should trigger different behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Continuation from #1556
Finally found the time to cherry-pick my added commits to a new branch to make reviewing and merging easier
PR Checklist:
pre-commit run --all-files)pytest)