Conversation
|
@jsignell Thanks for looking into this. Yes, you are right. |
bb4d0e6 to
48f7a12
Compare
|
Ok! I just force pushed to your branch to tidy up the history. |
pystac/extensions/ext.py
Outdated
| "version", | ||
| "view", | ||
| "xarray", | ||
| "archive", |
There was a problem hiding this comment.
This seems to be sorted alphabetically.
There was a problem hiding this comment.
Thank you very much. I made the necessary modifications to maintain the alphabetical order.
gadomski
left a comment
There was a problem hiding this comment.
Still doesn't have any tests that exercise the new behavior. Please see other extensions (e.g. proj) for examples of the kind of tests we include with extensions.
|
@gadomski Sorry for the delay in reverting back, i noticed that the 'archive' extension specification https://github.com/stac-extensions/archive was updated a few weeks ago and accordingly the extension implementation has been modified. The test scripts, data files and the cassette files have been added to the repo. Thank you. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
- Coverage 92.22% 92.20% -0.03%
==========================================
Files 55 56 +1
Lines 8414 8609 +195
Branches 973 981 +8
==========================================
+ Hits 7760 7938 +178
- Misses 466 481 +15
- Partials 188 190 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gadomski Lint error fixed. Only the mypy error is still remaining. Thanks. |
Related Issue(s):
Description:
Prototype Implementation of archive extension.
PR Checklist:
pre-commit run --all-files)pytest)